zhouchijian
/
fe-drone-ci
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix[ExternalLink]: fixed bug when url include chinese #1182

This commit is contained in:
Pan 2018-10-10 17:43:33 +08:00
parent 90d3e314c0
commit 323408f8d9
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/utils/index.js
View File

@ -296,3 +296,7 @@ export function deepClone(source) {
export function uniqueArr(arr) { export function uniqueArr(arr) {
return Array.from(new Set(arr)) return Array.from(new Set(arr))
} }
export function isExternal(path) {
return /^(https?:|mailto:|tel:)/.test(path)
}

4
src/views/layout/components/Sidebar/Link.vue
View File

@ -7,7 +7,7 @@
</template> </template>
<script> <script>
import { validateURL } from '@/utils/validate' import { isExternal } from '@/utils'
export default { export default {
props: { props: {
@ -18,7 +18,7 @@ export default {
}, },
methods: { methods: {
isExternalLink(routePath) { isExternalLink(routePath) {
return validateURL(routePath) return isExternal(routePath)
}, },
linkProps(url) { linkProps(url) {
if (this.isExternalLink(url)) { if (this.isExternalLink(url)) {

4
src/views/layout/components/Sidebar/SidebarItem.vue
View File

@ -37,7 +37,7 @@
<script> <script>
import path from 'path' import path from 'path'
import { generateTitle } from '@/utils/i18n' import { generateTitle } from '@/utils/i18n'
import { validateURL } from '@/utils/validate' import { isExternal } from '@/utils'
import Item from './Item' import Item from './Item'
import AppLink from './Link' import AppLink from './Link'
import FixiOSBug from './FixiOSBug' import FixiOSBug from './FixiOSBug'
@ -98,7 +98,7 @@ export default {
return path.resolve(this.basePath, routePath) return path.resolve(this.basePath, routePath)
}, },
isExternalLink(routePath) { isExternalLink(routePath) {
return validateURL(routePath) return isExternal(routePath)
}, },
generateTitle generateTitle
} }