rewrite the code to make it elegant

This commit is contained in:
Alex 2018-11-02 14:32:31 +08:00
parent fd1bdec706
commit 4b2bfd5610
2 changed files with 4 additions and 12 deletions

View File

@ -10,16 +10,12 @@ export default {
window.addEventListener('resize', this.__resizeHandler) window.addEventListener('resize', this.__resizeHandler)
this.sidebarElm = document.getElementsByClassName('sidebar-container')[0] this.sidebarElm = document.getElementsByClassName('sidebar-container')[0]
if (this.sidebarElm) { this.sidebarElm && this.sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
this.sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
}
}, },
beforeDestroy() { beforeDestroy() {
window.removeEventListener('resize', this.__resizeHandler) window.removeEventListener('resize', this.__resizeHandler)
if (this.sidebarElm) { this.sidebarElm && this.sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
this.sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
}
}, },
methods: { methods: {
sidebarResizeHandler(e) { sidebarResizeHandler(e) {

View File

@ -56,9 +56,7 @@ export default {
// //
this.sidebarElm = document.getElementsByClassName('sidebar-container')[0] this.sidebarElm = document.getElementsByClassName('sidebar-container')[0]
if (this.sidebarElm) { this.sidebarElm && this.sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
this.sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
}
}, },
beforeDestroy() { beforeDestroy() {
if (!this.chart) { if (!this.chart) {
@ -68,9 +66,7 @@ export default {
window.removeEventListener('resize', this.__resizeHandler) window.removeEventListener('resize', this.__resizeHandler)
} }
if (this.sidebarElm) { this.sidebarElm && this.sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
this.sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
}
this.chart.dispose() this.chart.dispose()
this.chart = null this.chart = null