From 3e4fbb1b0cb09397915af17a34e2b706eafe2c37 Mon Sep 17 00:00:00 2001 From: Aisen60 Date: Fri, 18 Sep 2020 13:08:15 +0800 Subject: [PATCH 1/2] fix: fix an error when the validLowerCase and validUpperCase function have no params --- src/utils/validate.js | 2 ++ tests/unit/utils/validate.spec.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/utils/validate.js b/src/utils/validate.js index 6b3ac418..76bc0b6b 100644 --- a/src/utils/validate.js +++ b/src/utils/validate.js @@ -33,6 +33,7 @@ export function validURL(url) { * @returns {Boolean} */ export function validLowerCase(str) { + if (str === undefined || str === null) return false const reg = /^[a-z]+$/ return reg.test(str) } @@ -42,6 +43,7 @@ export function validLowerCase(str) { * @returns {Boolean} */ export function validUpperCase(str) { + if (str === undefined || str === null) return false const reg = /^[A-Z]+$/ return reg.test(str) } diff --git a/tests/unit/utils/validate.spec.js b/tests/unit/utils/validate.spec.js index ef2efe61..595d5441 100644 --- a/tests/unit/utils/validate.spec.js +++ b/tests/unit/utils/validate.spec.js @@ -14,11 +14,13 @@ describe('Utils:validate', () => { expect(validLowerCase('abc')).toBe(true) expect(validLowerCase('Abc')).toBe(false) expect(validLowerCase('123abc')).toBe(false) + expect(validLowerCase()).toBe(false) }) it('validUpperCase', () => { expect(validUpperCase('ABC')).toBe(true) expect(validUpperCase('Abc')).toBe(false) expect(validUpperCase('123ABC')).toBe(false) + expect(validUpperCase()).toBe(false) }) it('validAlphabets', () => { expect(validAlphabets('ABC')).toBe(true) From 47244302fff839f3033dc130c0c11017a0b59999 Mon Sep 17 00:00:00 2001 From: Aisen60 Date: Fri, 18 Sep 2020 13:14:50 +0800 Subject: [PATCH 2/2] fix: fix an error when the validLowerCase and validUpperCase function have no params --- src/utils/validate.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/utils/validate.js b/src/utils/validate.js index 76bc0b6b..3e91b294 100644 --- a/src/utils/validate.js +++ b/src/utils/validate.js @@ -33,6 +33,7 @@ export function validURL(url) { * @returns {Boolean} */ export function validLowerCase(str) { + // https://www.coder.work/article/1041931 if (str === undefined || str === null) return false const reg = /^[a-z]+$/ return reg.test(str) @@ -43,6 +44,7 @@ export function validLowerCase(str) { * @returns {Boolean} */ export function validUpperCase(str) { + // https://www.coder.work/article/1041931 if (str === undefined || str === null) return false const reg = /^[A-Z]+$/ return reg.test(str)