From 583e96cca5fff1e9543f4e23fb96334a0906ffaa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=8A=B1=E8=A3=A4=E8=A1=A9?= <panfree23@gmail.com>
Date: Tue, 5 Mar 2019 13:20:30 +0800
Subject: [PATCH] perf[TagsView]: set the scrollPane as a business component
 (#1660)

---
 .../layout/components/TagsView/ScrollPane.vue}         | 10 ++++++++--
 .../components/{TagsView.vue => TagsView/index.vue}    |  7 ++-----
 src/views/layout/components/index.js                   |  2 +-
 3 files changed, 11 insertions(+), 8 deletions(-)
 rename src/{components/ScrollPane/index.vue => views/layout/components/TagsView/ScrollPane.vue} (91%)
 rename src/views/layout/components/{TagsView.vue => TagsView/index.vue} (99%)

diff --git a/src/components/ScrollPane/index.vue b/src/views/layout/components/TagsView/ScrollPane.vue
similarity index 91%
rename from src/components/ScrollPane/index.vue
rename to src/views/layout/components/TagsView/ScrollPane.vue
index 172afccc..820a536e 100644
--- a/src/components/ScrollPane/index.vue
+++ b/src/views/layout/components/TagsView/ScrollPane.vue
@@ -14,16 +14,21 @@ export default {
       left: 0
     }
   },
+  computed: {
+    scrollWrapper() {
+      return this.$refs.scrollContainer.$refs.wrap
+    }
+  },
   methods: {
     handleScroll(e) {
       const eventDelta = e.wheelDelta || -e.deltaY * 40
-      const $scrollWrapper = this.$refs.scrollContainer.$refs.wrap
+      const $scrollWrapper = this.scrollWrapper
       $scrollWrapper.scrollLeft = $scrollWrapper.scrollLeft + eventDelta / 4
     },
     moveToTarget(currentTag) {
       const $container = this.$refs.scrollContainer.$el
       const $containerWidth = $container.offsetWidth
-      const $scrollWrapper = this.$refs.scrollContainer.$refs.wrap
+      const $scrollWrapper = this.scrollWrapper
       const tagList = this.$parent.$refs.tag
 
       let firstTag = null
@@ -44,6 +49,7 @@ export default {
         const currentIndex = tagList.findIndex(item => item === currentTag)
         const prevTag = tagList[currentIndex - 1]
         const nextTag = tagList[currentIndex + 1]
+
         // the tag's offsetLeft after of nextTag
         const afterNextTagOffsetLeft = nextTag.$el.offsetLeft + nextTag.$el.offsetWidth + tagAndTagSpacing
 
diff --git a/src/views/layout/components/TagsView.vue b/src/views/layout/components/TagsView/index.vue
similarity index 99%
rename from src/views/layout/components/TagsView.vue
rename to src/views/layout/components/TagsView/index.vue
index 66059816..53d592bc 100644
--- a/src/views/layout/components/TagsView.vue
+++ b/src/views/layout/components/TagsView/index.vue
@@ -26,7 +26,7 @@
 </template>
 
 <script>
-import ScrollPane from '@/components/ScrollPane'
+import ScrollPane from './ScrollPane'
 import { generateTitle } from '@/utils/i18n'
 import path from 'path'
 
@@ -90,7 +90,6 @@ export default {
           }
         }
       })
-
       return tags
     },
     initTags() {
@@ -115,12 +114,10 @@ export default {
         for (const tag of tags) {
           if (tag.to.path === this.$route.path) {
             this.$refs.scrollPane.moveToTarget(tag)
-
             // when query is different then update
             if (tag.to.fullPath !== this.$route.fullPath) {
               this.$store.dispatch('updateVisitedView', this.$route)
             }
-
             break
           }
         }
@@ -178,8 +175,8 @@ export default {
       } else {
         this.left = left
       }
-      this.top = e.clientY
 
+      this.top = e.clientY
       this.visible = true
       this.selectedTag = tag
     },
diff --git a/src/views/layout/components/index.js b/src/views/layout/components/index.js
index 07cc9947..5262e113 100644
--- a/src/views/layout/components/index.js
+++ b/src/views/layout/components/index.js
@@ -1,4 +1,4 @@
 export { default as Navbar } from './Navbar'
 export { default as Sidebar } from './Sidebar/index.vue'
-export { default as TagsView } from './TagsView'
+export { default as TagsView } from './TagsView/index.vue'
 export { default as AppMain } from './AppMain'