perf: fixed eslint errors

2019-02-01 14:09:29 +08:00
parent 3b9abde89a
commit 6e42b4c896
3 changed files with 18 additions and 19 deletions
--- a/src/views/layout/components/Sidebar/Link.vue
+++ b/src/views/layout/components/Sidebar/Link.vue
@@ -1,6 +1,6 @@

 <template>
-  <!-- eslint-disable vue/require-component-is-->
+  <!-- eslint-disable vue/require-component-is -->
  <component v-bind="linkProps(to)">
    <slot/>
  </component>
@@ -17,11 +17,8 @@ export default {
    }
  },
  methods: {
-    isExternalLink(routePath) {
-      return isExternal(routePath)
-    },
    linkProps(url) {
-      if (this.isExternalLink(url)) {
+      if (isExternal(url)) {
        return {
          is: 'a',
          href: url,