zhouchijian/fe-drone-ci
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

perf: set private property names for vue

Browse Source 
https://vuejs.org/v2/style-guide/index.html#Private-property-names-essential
This commit is contained in:
Pan
2019-04-12 10:53:12 +08:00
parent d0651ad2f2
commit a6be6af46d
2 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/layout/mixin/ResizeHandler.js
View File

@@ -12,26 +12,28 @@ export default {
}
},
beforeMount() {
window.addEventListener('resize', this.resizeHandler)
window.addEventListener('resize', this.$_resizeHandler)
},
beforeDestroy() {
window.removeEventListener('resize', this.resizeHandler)
window.removeEventListener('resize', this.$_resizeHandler)
},
mounted() {
const isMobile = this.isMobile()
const isMobile = this.$_isMobile()
if (isMobile) {
store.dispatch('app/toggleDevice', 'mobile')
store.dispatch('app/closeSideBar', { withoutAnimation: true })
}
},
methods: {
isMobile() {
// use $_ for mixins properties
// https://vuejs.org/v2/style-guide/index.html#Private-property-names-essential
$_isMobile() {
const rect = body.getBoundingClientRect()
return rect.width - 1 < WIDTH
},
resizeHandler() {
$_resizeHandler() {
if (!document.hidden) {
const isMobile = this.isMobile()
const isMobile = this.$_isMobile()
store.dispatch('app/toggleDevice', isMobile ? 'mobile' : 'desktop')
if (isMobile) {